Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use codegen_select in vtable_trait_upcasting_coercion_new_vptr_slot #103861

Merged
merged 1 commit into from
Nov 6, 2022
Merged

Use codegen_select in vtable_trait_upcasting_coercion_new_vptr_slot #103861

merged 1 commit into from
Nov 6, 2022

Conversation

compiler-errors
Copy link
Member

A super tiny clean up

@rustbot
Copy link
Collaborator

rustbot commented Nov 2, 2022

r? @nagisa

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 2, 2022
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 2, 2022
@bors
Copy link
Contributor

bors commented Nov 2, 2022

⌛ Trying commit 20bb56e with merge 62d84d6d284f82beb42154f057d565e919196a63...

@bors
Copy link
Contributor

bors commented Nov 2, 2022

☀️ Try build successful - checks-actions
Build commit: 62d84d6d284f82beb42154f057d565e919196a63 (62d84d6d284f82beb42154f057d565e919196a63)

@rust-timer
Copy link
Collaborator

Queued 62d84d6d284f82beb42154f057d565e919196a63 with parent 11ebe65, future comparison URL.

@compiler-errors
Copy link
Member Author

Rust-timer didnt respond but the perf results came back neutral: https://perf.rust-lang.org/compare.html?start=11ebe6512b4c77633c59f8dcdd421df3b79d1a9f&end=62d84d6d284f82beb42154f057d565e919196a63

@compiler-errors compiler-errors removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 3, 2022
@nagisa
Copy link
Member

nagisa commented Nov 4, 2022

@bors r+

Looks okay to me. I’m not 100% familiar with this code, but given that vtable_trait_upcasting_coercion_new_vptr_slot is called from codegen only, this seems like an appropriate use of codegen_select_candidate.

That said, although the perf results came out neutral, codegen_select_candidate seems to be doing a bunch more. I suspect we're just not exercising this code path much, so if there was an actual regression, it would be hard to see here. Which I guess is fine either way – if the code path is not exercised much, we probably shouldn’t worry about small perf differences for that code anyway.

@bors
Copy link
Contributor

bors commented Nov 4, 2022

📌 Commit 20bb56e has been approved by nagisa

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2022
@bors
Copy link
Contributor

bors commented Nov 6, 2022

⌛ Testing commit 20bb56e with merge 1e1e5b8...

@bors
Copy link
Contributor

bors commented Nov 6, 2022

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing 1e1e5b8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 6, 2022
@bors bors merged commit 1e1e5b8 into rust-lang:master Nov 6, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 6, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1e1e5b8): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.4% [0.4%, 0.5%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.4% [0.4%, 0.5%] 2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.9% [0.9%, 0.9%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.9% [0.9%, 0.9%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.6% [0.6%, 0.6%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.6% [0.6%, 0.6%] 1

Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#103861 - compiler-errors:codegen-select-in-vt…
d2d5551 
…able-slot, r=nagisa

Use `codegen_select` in `vtable_trait_upcasting_coercion_new_vptr_slot`

A super tiny clean up
@compiler-errors compiler-errors deleted the codegen-select-in-vtable-slot branch August 11, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nagisa nagisa

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @rust-timer @bors @nagisa